Skip to content

Make sure to apply the theme on load of the application - #2107

Merged
Michael Niksa (miniksa) merged 1 commit into
masterfrom
dev/migrie/b/1913-theme-on-load
Jul 25, 2019
Merged

Michael Niksa (miniksa) merged 1 commit into
masterfrom
dev/migrie/b/1913-theme-on-load

Conversation

@zadjii-msft

Copy link
Copy Markdown
Member

Fixes #1913.

_AplyTheme raises an event for the IslandWindow to handle and actually apply
the theme, so we don't really need to worry about it, but we do need to
worry for ContentDialogs.

PR Checklist

  Fixes #1913.

  _AplyTheme raises an event for the IslandWindow to handle and actually apply
  the theme, so we don't _really_ need to worry about it, but we do need to
  worry for ContentDialogs.
@zadjii-msft Mike Griese (zadjii-msft) added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jul 25, 2019
@zadjii-msft
Mike Griese (zadjii-msft) requested a review from a team July 25, 2019 19:52
@miniksa
Michael Niksa (miniksa) merged commit a574685 into master Jul 25, 2019
@miniksa
Michael Niksa (miniksa) deleted the dev/migrie/b/1913-theme-on-load branch July 25, 2019 20:25
Wojciech Litewka (mcpiroman) pushed a commit to mcpiroman/terminal that referenced this pull request Jul 26, 2019
Fixes microsoft#1913.

  _AplyTheme raises an event for the IslandWindow to handle and actually apply
  the theme, so we don't _really_ need to worry about it, but we do need to
  worry for ContentDialogs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: Dark Theme requires settings reload

3 participants